-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Lexer: check in advance_token
to avoid regard spare ##
as GardedStrPrefix
#141028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xizheyin
wants to merge
2
commits into
rust-lang:master
Choose a base branch
from
xizheyin:issue-140618
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 36 additions & 0 deletions
36
tests/ui/rust-2024/reverved-guarded-string-too-many-terminators-issue-140618.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
//@ edition:2024 | ||
|
||
fn f0(){ | ||
r#"ok0!"#; | ||
} | ||
|
||
fn f1(){ | ||
r#"ok1!"##; | ||
//~^ ERROR too many `#` when terminating raw string | ||
} | ||
|
||
|
||
fn f2(){ | ||
r#"ok2!"###; | ||
//~^ ERROR too many `#` when terminating raw string | ||
} | ||
|
||
fn f3(){ | ||
#"ok3!"#; | ||
//~^ ERROR invalid string literal | ||
} | ||
|
||
|
||
fn f4(){ | ||
#"ok4!"##; | ||
//~^ ERROR invalid string literal | ||
//~| ERROR expected one of `.`, `;`, `?`, `}`, or an operator, found `#` | ||
} | ||
|
||
fn f5(){ | ||
#"ok5!"###; | ||
//~^ ERROR invalid string literal | ||
//~| ERROR expected one of `.`, `;`, `?`, `}`, or an operator, found `#` | ||
} | ||
|
||
fn main() {} |
66 changes: 66 additions & 0 deletions
66
tests/ui/rust-2024/reverved-guarded-string-too-many-terminators-issue-140618.stderr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
error: invalid string literal | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:19:5 | ||
| | ||
LL | #"ok3!"#; | ||
| ^^^^^^^^ | ||
| | ||
= note: unprefixed guarded string literals are reserved for future use since Rust 2024 | ||
help: consider inserting whitespace here | ||
| | ||
LL | # "ok3!"#; | ||
| + | ||
|
||
error: invalid string literal | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:25:5 | ||
| | ||
LL | #"ok4!"##; | ||
| ^^^^^^^^ | ||
| | ||
= note: unprefixed guarded string literals are reserved for future use since Rust 2024 | ||
help: consider inserting whitespace here | ||
| | ||
LL | # "ok4!"##; | ||
| + | ||
|
||
error: invalid string literal | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:31:5 | ||
| | ||
LL | #"ok5!"###; | ||
| ^^^^^^^^ | ||
| | ||
= note: unprefixed guarded string literals are reserved for future use since Rust 2024 | ||
help: consider inserting whitespace here | ||
| | ||
LL | # "ok5!"###; | ||
| + | ||
|
||
error: too many `#` when terminating raw string | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:8:14 | ||
| | ||
LL | r#"ok1!"##; | ||
| ---------^ help: remove the extra `#` | ||
| | | ||
| this raw string started with 1 `#` | ||
|
||
error: too many `#` when terminating raw string | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:14:14 | ||
| | ||
LL | r#"ok2!"###; | ||
| ---------^^ help: remove the extra `#`s | ||
| | | ||
| this raw string started with 1 `#` | ||
|
||
error: expected one of `.`, `;`, `?`, `}`, or an operator, found `#` | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:25:13 | ||
| | ||
LL | #"ok4!"##; | ||
| ^ expected one of `.`, `;`, `?`, `}`, or an operator | ||
|
||
error: expected one of `.`, `;`, `?`, `}`, or an operator, found `#` | ||
--> $DIR/reverved-guarded-string-too-many-terminators-issue-140618.rs:31:13 | ||
| | ||
LL | #"ok5!"###; | ||
| ^ expected one of `.`, `;`, `?`, `}`, or an operator | ||
|
||
error: aborting due to 7 previous errors | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
self.prev() is only for debug builds (read its documentation)