refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking #141162

mejrs · 2025-05-17T23:04:58Z

First commit changes the following:

AttributeGate from an enum with (four) tuple fields to (five) named fields
adds a notes fields that is emitted as notes in the PostExpansionVisitor pass
removes the this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date note if the feature gate is rustc_attrs.
various phrasing changes and touchups
and finally, the reason why I went down this path to begin with: tell people they can use the diagnostic namespace when they hit the rustc_on_unimplemented feature gate 🙈

Second commit removes unused machinery for deprecated attributes

rustbot · 2025-05-17T23:05:03Z

rustbot has assigned @SparrowLii.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

mejrs · 2025-05-17T23:13:10Z

compiler/rustc_lint/src/builtin.rs

-                        BuiltinDeprecatedAttrLink { name, reason, link, suggestion },
+                        BuiltinDeprecatedAttrLink { name: *name, message, link, suggestion },


It looks like this code had some shadowing issues causing name to refer to the feature gate name, not the attribute. So I've changed it, but note that I think this function is dead code.

Hmmmmm. Why? If this is dead code then something is wrong. Could we add a test for deprecated attributes?

Hmmmmm. Why? If this is dead code then something is wrong. Could we add a test for deprecated attributes?

There are no deprecated attributes. Actually, #[macro_escape] is deprecated but it's not marked at such because it has its own diagnostic in rustc_resolve instead. This error has a branch on whether it's used as an inner or outer attribute, which the rustc_feature machinery does not support.

Rather than figure out some way to test this, I'd prefer to delete rustc_feature::Stability and this DeprecatedAttr lint pass instead, and have deprecations be done in check_attr.rs or in the new attribute parsing infra instead.

If you want to do it, feel free to. I'll mark this down as a followup on my to-do list (I will check it out later).

Removed in 16ae839

workingjubilee · 2025-05-18T03:55:02Z

cc @jdonszelmann

jdonszelmann · 2025-05-18T06:29:50Z

I'll take a look

mejrs · 2025-06-03T17:44:56Z

r? compiler

fee1-dead

Overall the direction seems fine.

compiler/rustc_feature/src/builtin_attrs.rs

fee1-dead · 2025-06-04T04:26:11Z

compiler/rustc_lint/src/builtin.rs

-                        BuiltinDeprecatedAttrLink { name, reason, link, suggestion },
+                        BuiltinDeprecatedAttrLink { name: *name, message, link, suggestion },


Hmmmmm. Why? If this is dead code then something is wrong. Could we add a test for deprecated attributes?

compiler/rustc_feature/src/builtin_attrs.rs

mejrs · 2025-06-04T19:29:15Z

@rustbot ready

fee1-dead

r=me after the nit.

compiler/rustc_feature/src/builtin_attrs.rs

mejrs · 2025-06-06T10:40:34Z

@rustbot ready

fee1-dead · 2025-06-09T07:02:54Z

Could you please squash this PR so it is two commits? One that is the refactor and one that is removing the stability.

…re checking

mejrs · 2025-06-09T10:00:48Z

Done

fee1-dead · 2025-06-11T13:16:07Z

@bors r+

bors · 2025-06-11T13:16:10Z

📌 Commit 81eb182 has been approved by fee1-dead

It is now in the queue for this repository.

refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking First commit changes the following: - `AttributeGate ` from an enum with (four) tuple fields to (five) named fields - adds a `notes` fields that is emitted as notes in the `PostExpansionVisitor` pass - removes the `this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date` note if the feature gate is `rustc_attrs`. - various phrasing changes and touchups - and finally, the reason why I went down this path to begin with: tell people they can use the diagnostic namespace when they hit the rustc_on_unimplemented feature gate 🙈 Second commit removes unused machinery for deprecated attributes

Rollup of 9 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #140770 (add `extern "custom"` functions) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142135 (docs: autogenerate compiler flag stubs based on -Zhelp) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) - #142353 (compiler: Ease off the accelerator on `unsupported_calling_conventions`) r? `@ghost` `@rustbot` modify labels: rollup

refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking First commit changes the following: - `AttributeGate ` from an enum with (four) tuple fields to (five) named fields - adds a `notes` fields that is emitted as notes in the `PostExpansionVisitor` pass - removes the `this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date` note if the feature gate is `rustc_attrs`. - various phrasing changes and touchups - and finally, the reason why I went down this path to begin with: tell people they can use the diagnostic namespace when they hit the rustc_on_unimplemented feature gate 🙈 Second commit removes unused machinery for deprecated attributes

Rollup of 8 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #140770 (add `extern "custom"` functions) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) - #142353 (compiler: Ease off the accelerator on `unsupported_calling_conventions`) r? `@ghost` `@rustbot` modify labels: rollup

refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking First commit changes the following: - `AttributeGate ` from an enum with (four) tuple fields to (five) named fields - adds a `notes` fields that is emitted as notes in the `PostExpansionVisitor` pass - removes the `this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date` note if the feature gate is `rustc_attrs`. - various phrasing changes and touchups - and finally, the reason why I went down this path to begin with: tell people they can use the diagnostic namespace when they hit the rustc_on_unimplemented feature gate 🙈 Second commit removes unused machinery for deprecated attributes

Rollup of 7 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) - #142353 (compiler: Ease off the accelerator on `unsupported_calling_conventions`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 6 pull requests Successful merges: - #138016 (Added `Clone` implementation for `ChunkBy`) - #141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - #141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - #141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - #142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - #142337 (miri: add flag to suppress float non-determinism) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #141162 - mejrs:gated, r=fee1-dead refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking First commit changes the following: - `AttributeGate ` from an enum with (four) tuple fields to (five) named fields - adds a `notes` fields that is emitted as notes in the `PostExpansionVisitor` pass - removes the `this compiler was built on YYYY-MM-DD; consider upgrading it if it is out of date` note if the feature gate is `rustc_attrs`. - various phrasing changes and touchups - and finally, the reason why I went down this path to begin with: tell people they can use the diagnostic namespace when they hit the rustc_on_unimplemented feature gate 🙈 Second commit removes unused machinery for deprecated attributes

Rollup of 6 pull requests Successful merges: - rust-lang/rust#138016 (Added `Clone` implementation for `ChunkBy`) - rust-lang/rust#141162 (refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking) - rust-lang/rust#141474 (Add `ParseMode::Diagnostic` and fix multiline spans in diagnostic attribute lints) - rust-lang/rust#141947 (Specify that "option-like" enums must be `#[repr(Rust)]` to be ABI-compatible with their non-1ZST field.) - rust-lang/rust#142252 (Improve clarity of `core::sync::atomic` docs about "Considerations" in regards to CAS operations) - rust-lang/rust#142337 (miri: add flag to suppress float non-determinism) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned SparrowLii May 17, 2025

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 17, 2025

mejrs commented May 17, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

mejrs force-pushed the gated branch from af31954 to cfc3f05 Compare May 17, 2025 23:31

This comment has been minimized.

Sign in to view

mejrs force-pushed the gated branch from cfc3f05 to eedbf8b Compare May 18, 2025 16:35

rustbot assigned fee1-dead and unassigned SparrowLii Jun 3, 2025

fee1-dead requested changes Jun 4, 2025

View reviewed changes

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025

This comment has been minimized.

Sign in to view

mejrs force-pushed the gated branch from dd03323 to c2a5ff1 Compare June 4, 2025 10:33

This comment has been minimized.

Sign in to view

mejrs force-pushed the gated branch from f7317a6 to 82375df Compare June 4, 2025 15:56

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 4, 2025

fee1-dead requested changes Jun 6, 2025

View reviewed changes

compiler/rustc_feature/src/builtin_attrs.rs Outdated Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025

mejrs force-pushed the gated branch from 16ae839 to 2f6b6c6 Compare June 6, 2025 09:12

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 6, 2025

mejrs added 2 commits June 9, 2025 11:44

refactor AttributeGate and rustc_attr! to emit notes during featu…

959d6de

…re checking

Remove rustc_feature::Stability

81eb182

mejrs force-pushed the gated branch from 2f6b6c6 to 81eb182 Compare June 9, 2025 09:45

fee1-dead approved these changes Jun 11, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025

matthiaskrgr mentioned this pull request Jun 12, 2025

Rollup of 9 pull requests #142399

Closed

matthiaskrgr mentioned this pull request Jun 12, 2025

Rollup of 8 pull requests #142409

Closed

matthiaskrgr mentioned this pull request Jun 12, 2025

Rollup of 7 pull requests #142421

Closed

matthiaskrgr mentioned this pull request Jun 12, 2025

Rollup of 6 pull requests #142432

Merged

bors merged commit 2591439 into rust-lang:master Jun 13, 2025
10 checks passed

rustbot added this to the 1.89.0 milestone Jun 13, 2025

		BuiltinDeprecatedAttrLink { name, reason, link, suggestion },
		BuiltinDeprecatedAttrLink { name: *name, message, link, suggestion },

refactor AttributeGate and rustc_attr! to emit notes during feature checking #141162

refactor AttributeGate and rustc_attr! to emit notes during feature checking #141162

Uh oh!

Conversation

mejrs commented May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 17, 2025

Uh oh!

mejrs May 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fee1-dead Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

fee1-dead Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

mejrs Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

This comment has been minimized.

workingjubilee commented May 18, 2025

Uh oh!

jdonszelmann commented May 18, 2025

Uh oh!

mejrs commented Jun 3, 2025

Uh oh!

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

fee1-dead Jun 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mejrs commented Jun 4, 2025

Uh oh!

fee1-dead left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mejrs commented Jun 6, 2025

Uh oh!

fee1-dead commented Jun 9, 2025

Uh oh!

mejrs commented Jun 9, 2025

Uh oh!

fee1-dead commented Jun 11, 2025

Uh oh!

bors commented Jun 11, 2025

Uh oh!

Uh oh!

Uh oh!

refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking #141162

refactor `AttributeGate` and `rustc_attr!` to emit notes during feature checking #141162

mejrs commented May 17, 2025 •

edited

Loading

mejrs May 17, 2025 •

edited

Loading