Skip to content

Move coroutine_by_move_body_def_id into the big check_crate body owner loop #141950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 7, 2025

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Jun 3, 2025

This avoids starting a parallel loop in sequence and instead runs all the queries for a specific DefId together.

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 3, 2025
@oli-obk
Copy link
Contributor Author

oli-obk commented Jun 3, 2025

@bors2 try @rust-timer queue

@rust-timer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Jun 3, 2025

⌛ Trying commit 8a0fdbd with merge 591d990

rust-bors bot added a commit that referenced this pull request Jun 3, 2025
Move coroutine_by_move_body_def_id into the big check_crate body owner loop

This avoids starting a parallel loop in sequence and instead runs all the queries for a specific DefId together.
@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 3, 2025
@rust-bors
Copy link

rust-bors bot commented Jun 3, 2025

☀️ Try build successful (CI)
Build commit: 591d990 (591d9900b71965705c65b4f73ba23e8a856f57d5)

@rust-timer

This comment has been minimized.

Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after perf

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (591d990): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
-1.1% [-1.2%, -1.1%] 4
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results (primary 0.1%, secondary 2.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.6% [1.6%, 1.6%] 1
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
-1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [-1.5%, 1.6%] 2

Cycles

Results (secondary 1.1%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
3.3% [3.2%, 3.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-3.2% [-3.2%, -3.2%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 743.703s -> 742.807s (-0.12%)
Artifact size: 372.32 MiB -> 371.83 MiB (-0.13%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 3, 2025
@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 3, 2025

📌 Commit 8a0fdbd has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 3, 2025
@bors
Copy link
Collaborator

bors commented Jun 7, 2025

⌛ Testing commit 8a0fdbd with merge cdd545b...

@bors
Copy link
Collaborator

bors commented Jun 7, 2025

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing cdd545b to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2025
@bors bors merged commit cdd545b into rust-lang:master Jun 7, 2025
11 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
Copy link
Contributor

github-actions bot commented Jun 7, 2025

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2f2c8c3 (parent) -> cdd545b (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard cdd545be1b4f024d38360aa9f000dcb782fbc81b --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. dist-aarch64-linux: 5388.6s -> 7823.4s (45.2%)
  2. x86_64-apple-2: 3494.2s -> 4531.8s (29.7%)
  3. dist-x86_64-apple: 9327.4s -> 7823.9s (-16.1%)
  4. x86_64-apple-1: 5936.0s -> 6806.4s (14.7%)
  5. mingw-check-2: 2133.1s -> 1869.3s (-12.4%)
  6. dist-apple-various: 5916.3s -> 6555.7s (10.8%)
  7. dist-various-1: 4110.8s -> 4359.7s (6.1%)
  8. dist-armhf-linux: 4568.2s -> 4821.7s (5.5%)
  9. x86_64-gnu-debug: 5713.7s -> 5411.9s (-5.3%)
  10. x86_64-gnu-aux: 6256.8s -> 5940.5s (-5.1%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (cdd545b): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 1.6%, secondary 0.9%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.7% [4.7%, 4.7%] 1
Regressions ❌
(secondary)
4.3% [4.3%, 4.3%] 1
Improvements ✅
(primary)
-1.5% [-1.5%, -1.5%] 1
Improvements ✅
(secondary)
-2.5% [-2.5%, -2.5%] 1
All ❌✅ (primary) 1.6% [-1.5%, 4.7%] 2

Cycles

Results (secondary 6.0%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
6.0% [3.1%, 8.9%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 752.958s -> 754.268s (0.17%)
Artifact size: 372.44 MiB -> 372.43 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants