Skip to content

duduplicate more AST visitor methods #142086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 7, 2025

Conversation

fee1-dead
Copy link
Member

r? oli-obk

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 5, 2025
@rust-log-analyzer

This comment has been minimized.

@fee1-dead fee1-dead force-pushed the ast-visitor-dedup branch from 2dce81e to 8a7262c Compare June 6, 2025 05:18
@oli-obk
Copy link
Contributor

oli-obk commented Jun 6, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 6, 2025

📌 Commit 8a7262c has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2025
bors added a commit that referenced this pull request Jun 7, 2025
Rollup of 11 pull requests

Successful merges:

 - #140418 (Reexport types from `c_size_t` in `std`)
 - #141471 (unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract)
 - #141603 (Reduce `ast::ptr::P` to a typedef of `Box`)
 - #142043 (Verbose suggestion to make param `const`)
 - #142086 (duduplicate more AST visitor methods)
 - #142103 (Update `InterpCx::project_field` to take `FieldIdx`)
 - #142105 (remove extraneous text)
 - #142112 (fix typo)
 - #142113 (Reduce confusion of some drop order tests)
 - #142114 (Compute number of digits instead of relying on constant value for u128 display code)
 - #142118 (rustc_lexer: typo fix + small cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2946ce2 into rust-lang:master Jun 7, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 7, 2025
rust-timer added a commit that referenced this pull request Jun 7, 2025
Rollup merge of #142086 - fee1-dead-contrib:ast-visitor-dedup, r=oli-obk

duduplicate more AST visitor methods

r? oli-obk
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Jun 7, 2025
Rollup of 11 pull requests

Successful merges:

 - rust-lang/rust#140418 (Reexport types from `c_size_t` in `std`)
 - rust-lang/rust#141471 (unsafe keyword docs: emphasize that an unsafe fn in a trait does not get to choose its safety contract)
 - rust-lang/rust#141603 (Reduce `ast::ptr::P` to a typedef of `Box`)
 - rust-lang/rust#142043 (Verbose suggestion to make param `const`)
 - rust-lang/rust#142086 (duduplicate more AST visitor methods)
 - rust-lang/rust#142103 (Update `InterpCx::project_field` to take `FieldIdx`)
 - rust-lang/rust#142105 (remove extraneous text)
 - rust-lang/rust#142112 (fix typo)
 - rust-lang/rust#142113 (Reduce confusion of some drop order tests)
 - rust-lang/rust#142114 (Compute number of digits instead of relying on constant value for u128 display code)
 - rust-lang/rust#142118 (rustc_lexer: typo fix + small cleanups)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants