Skip to content

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording #142157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

rustc_resolve: Improve resolve_const_param_in_non_trivial_anon_const wording #142157

merged 1 commit into from
Jun 12, 2025

Conversation

Enselic
Copy link
Member

@Enselic Enselic commented Jun 7, 2025 •
edited by rustbot
Loading

In some contexts, const expressions are OK. Add a here to the error message to clarify this.

Closes #79429 which has 15 x 👍

@Enselic
rustc_resolve: Improve `resolve_const_param_in_non_trivial_anon_const…
4882ea4 
…` wording

In some contexts, const expressions are OK. Add a `here` to the error
message to clarify this.
@rustbot
Copy link
Collaborator

rustbot commented Jun 7, 2025

r? @petrochenkov

rustbot has assigned @petrochenkov.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 7, 2025
@Enselic Enselic mentioned this pull request Jun 7, 2025
Closed
compiler-errors
compiler-errors reviewed Jun 8, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, it would be really nice if we could actually pass a more rich description of the position that's disallowing the const, probably via the AnonConstKind, so that we don't have to say "here" but instead something like "in array repeat expressions" or "in const generic args" something.

Do you think that's something you could investigate? Otherwise, I'd like to reopen a new issue to make this suggestion more accurate.

@Enselic
Copy link
Member Author

Enselic commented Jun 9, 2025

Do you think that's something you could investigate? Otherwise, I'd like to reopen a new issue to make this suggestion more accurate.

I'm afraid I don't have time at the moment to investigate that, so opening a new issue sounds good.

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 11, 2025

📌 Commit 4882ea4 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2025
@compiler-errors compiler-errors mentioned this pull request Jun 11, 2025
Open
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 12, 2025
Merged
bors added a commit that referenced this pull request Jun 12, 2025
@bors
Auto merge of #142392 - matthiaskrgr:rollup-9jrfqnu, r=matthiaskrgr
fe5c95d 
Rollup of 10 pull requests

Successful merges:

 - #141307 (Add method to retrieve body of closure in stable-mir)
 - #142040 (transmutability: shift abstraction boundary)
 - #142066 (More simple 2015 edition test decoupling)
 - #142157 (rustc_resolve: Improve `resolve_const_param_in_non_trivial_anon_const` wording)
 - #142217 (`tests/ui`: A New Order [10/N])
 - #142219 (`tests/ui`: A New Order [11/N])
 - #142261 (use correct edition when warning for unsafe attributes)
 - #142303 (Assorted bootstrap cleanups (step 1))
 - #142318 (Cleanup `rust-src` remapping and real dir)
 - #142352 (compiler: Make `c_int_width` an integer)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2d9513b into rust-lang:master Jun 12, 2025
10 checks passed
@rustbot rustbot added this to the 1.89.0 milestone Jun 12, 2025
rust-timer added a commit that referenced this pull request Jun 12, 2025
@rust-timer
Unrolled build for #142157
099511f 
Rollup merge of #142157 - Enselic:trivial-anon-const-use-cases, r=compiler-errors

rustc_resolve: Improve `resolve_const_param_in_non_trivial_anon_const` wording

In some contexts, const expressions are OK. Add a `here` to the error message to clarify this.

Closes #79429 which has 15 x 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors left review comments

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.89.0
Development

Successfully merging this pull request may close these issues.

Inaccurate error message for const operations in type parameters
5 participants
@Enselic @rustbot @compiler-errors @bors @petrochenkov