Skip to content

Conversation

@cuviper
Copy link
Member

@cuviper cuviper commented Dec 4, 2025

cc @rust-lang/release
r? @BoxyUwU

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Dec 4, 2025
@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@cuviper
Copy link
Member Author

cuviper commented Dec 4, 2025

@rustbot ping relnotes-interest-group

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2025

Hi relnotes-interest-group, this issue/PR could use some help in reviewing /
adjusting release notes. Could you take a look if available? Thanks <3

cc @alex-semenyuk @jieyouxu @joshtriplett @Kobzol @lcnr @traviscross

@Kivooeo
Copy link
Member

Kivooeo commented Dec 4, 2025

Hi, sorry for being late with this

I wanted to ask about Release Notes for this change (#146810). We discussed this briefly on #t-compiler > Determining if a change needs release notes, but I’m still not completely sure whether they are required in my case. If they are needed, do I still have time to add them?

@cuviper
Copy link
Member Author

cuviper commented Dec 4, 2025

@Kivooeo that change is already included, but you can still suggest edits here, even removing that line if you don't think it deserves mention.

@Kivooeo
Copy link
Member

Kivooeo commented Dec 4, 2025

I meant a release blog section like here #147383

Because I still unsure about what changes require them

If this change is notable enough for inclusion in the blog post then this section should be edited to contain a draft for the blog post. Otherwise leave it empty.

This line is not clear enough to me, how can I understand if change is "notable enough"

@cuviper
Copy link
Member Author

cuviper commented Dec 4, 2025

Ah, the blog is much more subjective -- there's no real requirement, but it's essentially a judgement call about how many people may care about the change. @BoxyUwU is handling that in rust-lang/blog.rust-lang.org#1757.

Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one tiny nit

View changes since this review

@BoxyUwU
Copy link
Member

BoxyUwU commented Dec 8, 2025

this is now in the stable PR. if the commits could be squashed then this can be r+'d

@cuviper
Copy link
Member Author

cuviper commented Dec 8, 2025

@bors r=BoxyUwU rollup

@bors
Copy link
Collaborator

bors commented Dec 8, 2025

📌 Commit 90d2477 has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 8, 2025
Zalathar added a commit to Zalathar/rust that referenced this pull request Dec 9, 2025
Add release notes for 1.92.0

cc `@rust-lang/release`
r? `@BoxyUwU`
bors added a commit that referenced this pull request Dec 9, 2025
Rollup of 12 pull requests

Successful merges:

 - #147572 (std: Use more `unix.rs` code on WASI targets)
 - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type)
 - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation)
 - #149652 (Add release notes for 1.92.0)
 - #149720 (rustdoc book: mention inner doc attribute)
 - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE)
 - #149754 (Retire `opt_str2` from compiletest cli parsing)
 - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings)
 - #149763 (Add inline attribute to generated delegation function if needed)
 - #149772 (test: Add a test for 146133)
 - #149779 (Fix typo "an" → "and")
 - #149782 (Remove `[no-mentions]` handler in the triagebot config)

r? `@ghost`
`@rustbot` modify labels: rollup
bors added a commit that referenced this pull request Dec 9, 2025
Rollup of 11 pull requests

Successful merges:

 - #147585 (Suppress the error for private fields with non_exhaustive attribute)
 - #149215 (Emit `check-cfg` lints during attribute parsing rather than evaluation)
 - #149652 (Add release notes for 1.92.0)
 - #149720 (rustdoc book: mention inner doc attribute)
 - #149730 (lint: emit proper diagnostic for unsafe binders in improper_ctypes instead of ICE)
 - #149754 (Retire `opt_str2` from compiletest cli parsing)
 - #149755 (bootstrap: Use a `CompiletestMode` enum instead of bare strings)
 - #149763 (Add inline attribute to generated delegation function if needed)
 - #149772 (test: Add a test for 146133)
 - #149779 (Fix typo "an" → "and")
 - #149782 (Remove `[no-mentions]` handler in the triagebot config)

Failed merges:

 - #148491 ( Correctly provide suggestions when encountering `async fn` with a `dyn Trait` return type)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 990b663 into rust-lang:main Dec 9, 2025
11 checks passed
@rustbot rustbot added this to the 1.94.0 milestone Dec 9, 2025
rust-timer added a commit that referenced this pull request Dec 9, 2025
Rollup merge of #149652 - cuviper:relnotes-1.92.0, r=BoxyUwU

Add release notes for 1.92.0

cc ``@rust-lang/release``
r? ``@BoxyUwU``
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants