Skip to content

Conversation

@dradtke
Copy link

@dradtke dradtke commented Sep 22, 2014

This PR adds a new Vim compiler file specifically for use with Cargo. It passes all arguments through, so commands like :make build, :make clean, and :make run all work as expected.

It also adds a quickfix autocommand for fixing the paths before populating the error list. cargo build reports errors with file paths that are relative to Cargo.toml, so if you're further down in the project tree, then trying to open the error will result in a blank buffer because Vim treats that path as relative to the working directory instead. With this fix, the paths work properly no matter where you are in the project.

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

bors added a commit that referenced this pull request Sep 24, 2014
This PR adds a new Vim compiler file specifically for use with Cargo. It passes all arguments through, so commands like `:make build`, `:make clean`, and `:make run` all work as expected.

It also adds a quickfix autocommand for fixing the paths before populating the error list. `cargo build` reports errors with file paths that are relative to Cargo.toml, so if you're further down in the project tree, then trying to open the error will result in a blank buffer because Vim treats that path as relative to the working directory instead. With this fix, the paths work properly no matter where you are in the project.
@bors bors closed this Sep 24, 2014
@bors bors merged commit 59e750f into rust-lang:master Sep 24, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Jun 23, 2024
fix(completion): complete async keyword

Fixes rust-lang#17452

Not entirely confident of the fix here, but my logic is that `async` should in general be offered in similar semantic scenarios as other keywords like `static` or `pub`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants