Skip to content

Fix text overlap #49442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 29, 2018
Merged

Fix text overlap #49442

merged 1 commit into from
Mar 29, 2018
+55 −32

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Mar 28, 2018 •
edited
Loading

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 28, 2018
@QuietMisdreavus
Copy link
Contributor

Huh. Seems weird to just stick it into a table, but i'm not sure whether there's a better way to do it.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 28, 2018

📌 Commit 51f26ac has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 28, 2018
@GuillaumeGomez
Copy link
Member Author

We could using flex, but flex is weirdly supported until newest web browsers versions.

kennytm added a commit to kennytm/rust that referenced this pull request Mar 28, 2018
@kennytm
Rollup merge of rust-lang#49442 - GuillaumeGomez:text-overlap, r=Quie…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
5dc80dc 
…tMisdreavus

Fix text overlap

Fixes rust-lang#49006.

r? @QuietMisdreavus
@kennytm kennytm mentioned this pull request Mar 28, 2018
Merged
bors added a commit that referenced this pull request Mar 28, 2018
@bors
Auto merge of #49460 - kennytm:rollup, r=kennytm
d52c44e 
Rollup of 12 pull requests

- Successful merges: #49243, #49329, #49364, #49400, #49405, #49427, #49428, #49429, #49439, #49442, #49444, #49452
- Failed merges:
@bors bors merged commit 51f26ac into rust-lang:master Mar 29, 2018
@GuillaumeGomez GuillaumeGomez deleted the text-overlap branch March 29, 2018 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@QuietMisdreavus QuietMisdreavus

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@GuillaumeGomez @QuietMisdreavus @bors @rust-highfive