-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Remove unstable macro_reexport
#49982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
error[E0557]: feature has been removed | ||
--> $DIR/macro-reexport-removed.rs:13:12 | ||
| | ||
LL | #![feature(macro_reexport)] //~ ERROR feature has been removed | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This should probably have some note about why the feature was removed and what should be used instead. |
||
| ^^^^^^^^^^^^^^ | ||
| | ||
note: subsumed by `#![feature(use_extern_macros)]` and `pub use` | ||
--> $DIR/macro-reexport-removed.rs:13:12 | ||
| | ||
LL | #![feature(macro_reexport)] //~ ERROR feature has been removed | ||
| ^^^^^^^^^^^^^^ | ||
|
||
error[E0658]: The attribute `macro_reexport` is currently unknown to the compiler and may have meaning added to it in the future (see issue #29642) | ||
--> $DIR/macro-reexport-removed.rs:15:1 | ||
| | ||
LL | #[macro_reexport(macro_one)] //~ ERROR attribute `macro_reexport` is currently unknown | ||
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
| | ||
= help: add #![feature(custom_attribute)] to the crate attributes to enable | ||
|
||
error: aborting due to 2 previous errors | ||
|
||
Some errors occurred: E0557, E0658. | ||
For more information about an error, try `rustc --explain E0557`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petrochenkov: How likely are the changes in this file to cause crates to break, e.g. because of an unknown compiler bug? Phrased differently, do you think a crater run would make sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say unlikely.
If all local users of
libstd
like compiler and test suite build succesfully, then everything should be okay.