You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose we rename this repo to the rustc-dev-guide, to avoid confusion with the "rustc book" (and maybe we ought to rename that to the "rustc user's manual" or something, but that's a separate topic).
cc @rust-lang/compiler @rust-lang/wg-learning
JohnTitor, spastorino, amanjeev, mark-i-m, estebank and 3 more
We should fix the following links in the guide itself, though:
$ rg github.io/rustc-guideREADME.md6:[You can read the latest version of the guide here.](https://rust-lang.github.io/rustc-guide/)src/important-links.md14:[link](https://rust-lang.github.io/rustc-guide/stabilization_guide.html)15:[link](https://rust-lang.github.io/rustc-guide/stabilization_guide.html#updating-documentation)16:[link](https://rust-lang.github.io/rustc-guide/stabilization_guide.html#documentation-prs)src/implementing_new_features.md181:[here]: https://rust-lang.github.io/rustc-guide/stabilization_guide.htmlsrc/tests/running.md126:[mode]: https://rust-lang.github.io/rustc-guide/tests/adding.html#tests-that-do-not-result-in-compile-errors
Additionally, we will probably have broken links in the rust-lang/rust and rust-lang/forge repos in some readmes, I think...
I'm generally against renaming, as I think it will cause a lot of headaches. IMHO, those in favor of renaming should find the links that are going to break and make a list so that we can fix them.
@tshepang No I don't think so. TMK, Github only redirects links under github.com, not GitHub pages. That's why the forge has a manual list of redirects...
If we are trying to address subtle differences in names, maybe we should spell out “rust compiler dev guide” rather than rely on the single letter “c” for the distinction between “Rust development” and “rustc development”?
Activity
spastorino commentedon Oct 17, 2019
👍, I was confused also by the book and the guide existence too. Actually, I'd rename both things and the names you proposed seem great.
JohnTitor commentedon Oct 17, 2019
+1 from me, the renaming seems reasonable.
mark-i-m commentedon Oct 17, 2019
Alas, users strike again. I've always felt computer science would be way more fun if we had no users...
nikomatsakis commentedon Oct 17, 2019
Does anyone know -- if I rename the repo, will links to the rendered format also redirect?
eddyb commentedon Oct 17, 2019
All
github.com
links will redirect butgithub.io
ones won't.mark-i-m commentedon Oct 17, 2019
Yes, github will redirect the links.
We should fix the following links in the guide itself, though:
Additionally, we will probably have broken links in the rust-lang/rust and rust-lang/forge repos in some readmes, I think...
michaelwoerister commentedon Oct 21, 2019
👍 for renaming.
mark-i-m commentedon Nov 14, 2019
I'm generally against renaming, as I think it will cause a lot of headaches. IMHO, those in favor of renaming should find the links that are going to break and make a list so that we can fix them.
tshepang commentedon Dec 22, 2019
Should we worry about anything outside https://github.com/search?q=org%3Arust-lang+rust-lang.github.io%2Frustc-guide&type=Code?
mark-i-m commentedon Dec 22, 2019
@tshepang Perhaps we make the old address redirect to the new one or add a link like "are you looking for the rustc-dev-guide? Click here"
mark-i-m commentedon Dec 22, 2019
And we should maybe make a blog post
tshepang commentedon Dec 22, 2019
@mark-i-m if that's all the links we care for, won't we get redirects for free, then fix such links at our leisure?
mark-i-m commentedon Dec 22, 2019
@tshepang No I don't think so. TMK, Github only redirects links under github.com, not GitHub pages. That's why the forge has a manual list of redirects...
pnkfelix commentedon Dec 22, 2019
If we are trying to address subtle differences in names, maybe we should spell out “rust compiler dev guide” rather than rely on the single letter “c” for the distinction between “Rust development” and “rustc development”?
24 remaining items