Skip to content

Conversation

@vext01
Copy link
Contributor

@vext01 vext01 commented Nov 27, 2018

As mentioned here:
rust-lang/rust#52452 (comment)

It would be good is the rust compiler guide mentioned that the compiler tests need gdb with Python support.

Are there any other test dependencies that we should mention? If there are a few, perhaps we'd even want a subsection listing them.

Thanks

@eddyb
Copy link
Member

eddyb commented Nov 27, 2018

We should be detecting this. cc @michaelwoerister @tromey @Mark-Simulacrum

@vext01
Copy link
Contributor Author

vext01 commented Nov 27, 2018

We should be detecting this

I think that's also a good idea.

@vext01
Copy link
Contributor Author

vext01 commented Nov 27, 2018

The failure isn't mine, I don't think.

@Mark-Simulacrum
Copy link
Member

We should point users to the config.toml, not configure -- configure is primarily intended for automated scripts, whereas the user should edit config.toml manually (copying fields from config.toml.example).

@vext01
Copy link
Contributor Author

vext01 commented Nov 28, 2018

We should point users to the config.toml, not configure -- configure is primarily intended for automated scripts

I'm talking about the configure script distributed with the gdb source code.

Copy link
Contributor

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left one comment. I will wait for the discussion to converge on a decision, though.

@mark-i-m
Copy link
Contributor

Also, I restarted the build. It looked like a transient failure...

@tromey
Copy link
Contributor

tromey commented Nov 29, 2018

We should be detecting this

I filed rust-lang/rust#56346 for this.

@vext01
Copy link
Contributor Author

vext01 commented Dec 3, 2018

The last commit addresses @mark-i-m's comment.

@vext01
Copy link
Contributor Author

vext01 commented Dec 3, 2018

Another transient test failure

@vext01
Copy link
Contributor Author

vext01 commented Dec 3, 2018

Addressed @shepmaster's comment.

@mark-i-m mark-i-m merged commit 87830ff into rust-lang:master Dec 3, 2018
@mark-i-m
Copy link
Contributor

mark-i-m commented Dec 3, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants