Skip to content

Add support for doc benchmarks to graphs page #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kobzol merged 3 commits into from
Mar 2, 2023
Merged

Add support for doc benchmarks to graphs page #1531

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db10e3a
Enable doc summary in graphs page
Kobzol Mar 2, 2023
14df137
Enable doc profile in graph page
Kobzol Mar 2, 2023
1932351
Use four column layout on graph page
Kobzol Mar 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/request_handlers/graph.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ fn create_summary(
let mut summary_benchmark = HashMap::new();
let summary_query_cases = iproduct!(
ctxt.summary_scenarios(),
vec![Profile::Check, Profile::Debug, Profile::Opt]
vec![Profile::Check, Profile::Debug, Profile::Opt, Profile::Doc]
);
for (scenario, profile) in summary_query_cases {
let baseline = match baselines.entry((profile, scenario)) {
Expand Down
6 changes: 3 additions & 3 deletions site/static/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ <h3>This may take a while!</h3>

const otherCacheStateColors = ["#8085e9", "#f15c80", "#e4d354", "#2b908f", "#f45b5b", "#91e8e1"];
const interpolatedColor = "#fcb0f1";
const basicProfiles = ["Check", "Debug", "Opt"];
const profiles = ["Check", "Debug", "Opt", "Doc"];

function tooltipPlugin({ onclick, commits, isInterpolated, absoluteMode, shiftX = 10, shiftY = 10 }) {
let tooltipLeftOffset = 0;
Expand Down Expand Up @@ -385,7 +385,7 @@ <h3>This may take a while!</h3>

let plotOpts = genPlotOpts({
title: benchName + "-" + benchKind,
width: Math.floor(window.innerWidth / 3) - 16,
width: Math.floor(window.innerWidth / 4) - 16,
height: 300,
yAxisLabel,
series: seriesOpts,
Expand Down Expand Up @@ -426,7 +426,7 @@ <h3>This may take a while!</h3>
sortedBenchNames.forEach(name => {
benchmarks[name] = {};

for (let profile of basicProfiles) {
for (let profile of profiles) {
if (data.benchmarks[name].hasOwnProperty(profile)) {
benchmarks[name][profile.toLowerCase()] = optInterpolated(data.benchmarks[name][profile]);
}
Expand Down