Allow #[ignore] tests to run in rustfmt's test suite
#5397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Until #5395 is resolved it's expected that the rustfmt/tests/cargo-fmt/main.rs Lines 51 to 57 in 2c8b3be |
There are some tests in the rustfmt test suite that are ignored by default. I believe these tests are ignored because they have caused issues with the the `rust-lang/rust` test suite. However, we recently experienced an issue (5395) that would have been avoided had these tests been running. With the introduction of the new `#[rustfmt_only_ci_test]` attribute macro we can run these tests when the `RUSTFMT_CI` environment variable is set, which will presumably only be set during rustfmts CI runs. When the environment variable is not set the `#[rustfmt_only_ci_test]` will be replaced with an `#[ignore]`.
ytmimi
force-pushed
the
run_ignore_tests_on_rustfmt_ci
branch
from
dcf1e38 to
a64405f
Compare
calebcartwright
approved these changes
Jun 29, 2022
|
I'm hopeful that this will help us avoid situations like #5395 🤞🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some tests in the rustfmt test suite that are ignored by default. I believe these tests are ignored because they have caused issues with the the
rust-lang/rusttest suite.However, we recently experienced an issue (#5395) that would have been avoided had these tests been running.
With the introduction of the new
#[rustfmt_only_ci_test]attribute macro we can run these tests when theRUSTFMT_CIenvironment variable is set, which will presumably only be set during rustfmts CI runs. When the environment variable is not set the#[rustfmt_only_ci_test]will be replaced with an#[ignore].