Fix path resolution of rustfmt in cargo-fmt
#6566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like using |
|
Well, people can't build Does this PR bring any limitation/problem on |
|
I don't think I'd want to remove the |
|
Yeah, that's reasonable. I will do that tomorrow. |
It should be ready now. |
ytmimi
approved these changes
Jun 5, 2025
Instead of resolving `rustfmt` path from RUSTFMT or PATH envs, use the one located in the same directory as `cargo-fmt`. So that `cargo-fmt` uses the expected version of `rustfmt` to avoid accidental use of unrelated versions. Signed-off-by: onur-ozkan <[email protected]>
Signed-off-by: onur-ozkan <[email protected]>
ytmimi
added
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of resolving
rustfmtpath from RUSTFMT or PATH envs, use the one located in the same directory ascargo-fmt. So thatcargo-fmtuses the expected version ofrustfmtto avoid accidental use of unrelated versions.This shouldn't change anything on the current behavior but it should make it easier to test the bootstrapped
cargo-fmtin rust-lang/rust, since it currently always points to the globally installedrustfmt.Moved from rust-lang/rust#141100