Assert intrinsic implementations are inlined properly #261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ABI of types like `u8x8` as they're defined isn't actually the underlying type we need for LLVM, but only `__m64` currently satisfies that. Apparently this (and the casts involved) caused some extraneous instructions for a number of intrinsics. They've all moved over to the `__m64` type now to ensure that they're what the underlying interface is.
These should be harmless when evaluating whether we failed inlining
gnzlbg
reviewed
Jan 4, 2018
| // immediately followed by a `pop` to learn about the current address. | ||
| // Let's not take that into account when considering whether a function | ||
| // failed inlining something. | ||
| let followed_by_pop = function.instrs.get(i + 1) |
There was a problem hiding this comment.
how did you figure this out?
There was a problem hiding this comment.
Oh I look at the disassembly and recognized the instruction sequence. Additionally compiling with -C relocation-model=static made it go away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an assertion with the
assert_instrmacro that intrinsics aren't literally calling one another but rather everything is nice and inlined. This then touches up various intrinsics that accidentally had acallinstruction in their implementation.