Skip to content

Fix the recent breakage of the gba crate #704

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnzlbg merged 6 commits into from
Mar 18, 2019
Merged

Fix the recent breakage of the gba crate #704

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
41f0cdf
Limit this to sufficiently advanced devices
Lokathor Mar 11, 2019
779ccaf
add the double quotes
Lokathor Mar 11, 2019
0a9ac3e
oh, they both need double quotes, okay
Lokathor Mar 11, 2019
6894a28
Revert the regression, add a GBA target to avoid this again
Lokathor Mar 16, 2019
2a67651
I forgot that we need to install more
Lokathor Mar 16, 2019
9f887da
gnzlbg xargo doesn't work like you thought ;_;
Lokathor Mar 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/core_arch/src/acle/registers/aarch32.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/// Application Program Status Register
pub struct APSR;

#[cfg(any(not(target_feature = thumb-mode), target_feature = v6t2))]
Copy link

@parched parched Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to add quotes around the features I believe, and thumb-mode probably needs to be added to https://github.com/rust-lang/rust/blob/c2ddf5a1dd54ebe18ffb794e096c28a4ed8e1d16/src/librustc_codegen_llvm/llvm_util.rs#L96

Copy link
Contributor Author

@Lokathor Lokathor Mar 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh no! that's take a whole other PR first :/

rsr!(APSR);