Rc and Arc are missing new_cyclic_in #132
Description
new_cyclic was added in Rust 1.60 and allows users to create cyclic data structures without unsafe code; however, there is no equivalent new_cyclic_in. If this is an oversight, I'm happy to make a PR.
Metadata
Metadata
Assignees
Labels
No labels
Type
Projects
Milestone
Relationships
Development
No branches or pull requests
Participants
Activity
Amanieu commentedon Aug 29, 2024
Yes, this does seem to be an oversight, feel free to make a PR.
matthewpipie commentedon Aug 29, 2024
Great, I made a PR here: rust-lang/rust#129674.
I have a few outstanding questions in that PR. If you wouldn't mind taking a look at that, it would be much appreciated. I'm very new to the standard library and don't know some of its conventions.
matthewpipie commentedon Sep 5, 2024
Bump! Would love some feedback on if that PR is done appropriately.
zakarumych commentedon Sep 6, 2024
PR is still marked as "draft".
matthewpipie commentedon Sep 6, 2024
Thank you, fixed!
Rollup merge of rust-lang#129674 - matthewpipie:rc-arc-new-cyclic-in,…
Auto merge of rust-lang#129674 - matthewpipie:rc-arc-new-cyclic-in, r…
Rollup merge of rust-lang#129674 - matthewpipie:rc-arc-new-cyclic-in,…
Unrolled build for rust-lang#129674
matthewpipie commentedon Sep 17, 2024
Merged!
Rollup merge of #129674 - matthewpipie:rc-arc-new-cyclic-in, r=dtolnay