Add const vs. dynamic ndim to array Debug format #490
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between const-dimensional and dynamic-dimensional arrays is fairly significant, so it would be useful for the debug format to include this information. See also #489 for more motivation.
This implementation produces a debug format like this for a const-dimensional array:
and like this for a dynamic-dimensional array:
(Note the addition of
const ndim=2
ordynamic ndim=2
.)Is the term "fixed" better than "const"? I chose "const" because the number of dimensions is a compile-time constant, and Rust often uses the name "const" for this.