-
-
Notifications
You must be signed in to change notification settings - Fork 70
Implement the multiprocessor wakeup mechanism. #225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this! I've not tried to use the new mailbox interface myself, but it'd be cool to have support in the crate.
I've added some review comments around the implementation.
8ac4fac
to
e023d9d
Compare
Hi @IsaacWoods , could you review this PR again when you have time? Thanks~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks - this is organisationally good to go, just one remaining point re volatile writes to the mailbox.
The issue has been fixed. Thanks for your comments. @IsaacWoods |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks very much!
ACPI specification r6.4 introduced the Multiprocessor Wakeup Structure to let the bootstrap processor wake up application processors with a mailbox.
This PR follows the design and definition of ACPI specification and has been verified in my project.