Skip to content

Add a File::get_boxed_info_in using allocator_api #483

Closed
@benpye

Description

@benpye

It would be nice if we had a version of get_boxed_info that did not rely on the global allocator for use with the experimental feature allocator_api. I think there is sufficient support to return a boxed value with a specific allocator, specifically Box::from_raw_in.

I ended up writing this to use myself - I think it should look something like https://gist.github.com/benpye/b46a5d2ea1a0a59e037ae3522731d0e4

Activity

phip1611

phip1611 commented on Nov 20, 2022

@phip1611
Member

@nicholasbishop I think we can solve this easily once #559 is merged. I assigned the issue to me.

pinned this issue on Nov 20, 2022
self-assigned this
on Nov 20, 2022
phip1611

phip1611 commented on Nov 24, 2022

@phip1611
Member

Btw, as we do not have a internal discussion platform, I do it here: @nicholasbishop did you notice that I've pinged you on https://gitter.im/rust-osdev/Lobby? It'd be great if you can help

@nicholasbishop @GabrielMajeri
Would it make sense to have a dedicated communication channel (signal, Telegram) or are discussions on github sufficient?

GabrielMajeri

GabrielMajeri commented on Nov 25, 2022

@GabrielMajeri
Collaborator

@nicholasbishop @GabrielMajeri Would it make sense to have a dedicated communication channel (signal, Telegram) or are discussions on github sufficient?

Sorry, I haven't been able to catch up and help with uefi-rs lately because of schoolwork and some personal projects. We can use other communication channels, sure, but I'd be just as unresponsive there as I'm currently on GitHub 😅 so I don't necessarily see the point.

nicholasbishop

nicholasbishop commented on Nov 25, 2022

@nicholasbishop
Member

Thanks for the heads up, I didn't see that discussion on gitter.

Re a different communication channel, what about enabling Github Discussions on the repo? It's kinda similar to issues, but can encourage broader discussion than issues which tend to just get used for bug reports.

I prefer that over chats like gitter/discord/zulip, especially because it's searchable (gets indexed by Google etc) and makes it easier to respond when one has time as opposed to a live chat.

phip1611

phip1611 commented on Nov 25, 2022

@phip1611
Member

Actually, I just wasn't sure where totally unrelated things like "please look on gitter.im" and similar messages should be. I also assume such messages are very rare. Yeah, maybe the github discussions feature is what we need and a chat group overkill + has other disadvantages

unpinned this issue on Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

    Participants

    @benpye@nicholasbishop@GabrielMajeri@phip1611

    Issue actions

      Add a `File::get_boxed_info_in` using `allocator_api` · Issue #483 · rust-osdev/uefi-rs