Skip to content

xtask: Allow clippy::collapsible_if lint #1694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

Conversation

nicholasbishop
Copy link
Member

@nicholasbishop nicholasbishop commented Jun 8, 2025

Let-chains are being stabilized in 1.88, so this lint triggers on nightly. Since current stable is 1.87, we can't change the code to fix this lint, and we also can't use expect here. For now, the best solution is just to allow the lint.

Partial fix for #1687

Checklist

  • Sensible git history (for example, squash "typo" or "fix" commits). See the Rewriting History guide for help.
  • Update the changelog (if necessary)

Let-chains are being stabilized in 1.88, so this lint triggers on nightly. Since
current stable is 1.87, we can't change the code to fix this lint, and we also
can't use `expect` here. For now, the best solution is just to allow the lint.
@phip1611 phip1611 added this pull request to the merge queue Jun 10, 2025
Merged via the queue into main with commit 0a51c59 Jun 10, 2025
20 checks passed
@phip1611 phip1611 deleted the bishop-xtask-collapse-if branch June 10, 2025 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants