xtask: Allow clippy::collapsible_if lint #1694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let-chains are being stabilized in 1.88, so this lint triggers on nightly. Since current stable is 1.87, we can't change the code to fix this lint, and we also can't use `expect` here. For now, the best solution is just to allow the lint.
phip1611
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let-chains are being stabilized in 1.88, so this lint triggers on nightly. Since current stable is 1.87, we can't change the code to fix this lint, and we also can't use
expecthere. For now, the best solution is just to allow the lint.Partial fix for #1687
Checklist