uefi: Fix io-align == 0 edgecase handling for ata & nvme #1698
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@phip1611 If at all possible, I would really appreciate a quick merge of this one. |
phip1611
reviewed
Jun 10, 2025
| @@ -42,7 +42,9 @@ impl AtaPassThru { | |||
| /// The [`AtaPassThruMode`] structure containing configuration details of the protocol. | |||
| #[must_use] | |||
| pub fn mode(&self) -> AtaPassThruMode { | |||
| unsafe { (*self.0.mode).clone() } | |||
| let mut mode = unsafe { (*self.0.mode).clone() }; | |||
| mode.io_align = mode.io_align.max(1); // 0 and 1 is the same, says UEFI spec | |||
There was a problem hiding this comment.
For the record, this is documented here: https://uefi.org/specs/UEFI/2.10/13_Protocols_Media_Access.html#efi-ata-pass-thru-protocol
phip1611
approved these changes
Jun 10, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accidentally implemented it only for scsi.
And of course ... there are mainboards out there that hit this... and for some reason, they turned out to be in my vicinity (╯°□°）╯ ┻━┻
Checklist