Skip to content

Serde trait implementations for scraper::selectors::CssLocalName #243

Open
@JavesBastatas

Description

@JavesBastatas

Greetings!

I'm very glad that the scraper crate has support for serde crate through an optional feature flag (i.e: serde), which can be opted-in through the cargo add scraper --features serde command. However, I noticed that the trait implementations for the serde::Serialize and serde::Deserialize were missing on scraper::selectors::CssLocalName struct. I thought it has been implemented and provided by default.

Since the scraper crate didn't provide the required implementations, I implemented it all by myself for my own use-case scenario. Unfortunately, it is such a hassle to implement the necessary traits all over again across multiple projects. It's better if the scraper crate can provide the necessary implementations of serde::Deserialize and serde::Serialize traits in the first place. Even though the benefits are small, it is a one-step forward that propels better serde integration on this project.

I hope the developers of this project accepts my feature request. Thank you for reading!

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions