Skip to content

Don't install sage/tests/cmdline.py with meson #40252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

antonio-rojas
Copy link
Contributor

It contains tests that are not relevant for the meson build

We extract the test_executable function to __init__.py, since it is still used in other files, and leave only the tests in cmdline.py.

It contains tests that are not relevant for the meson build

We extract the test_executable function to __init__.py, since it is still used in other files, and leave only the tests in cmdline.py
@antonio-rojas antonio-rojas requested a review from tobiasdiez June 13, 2025 19:24
Copy link

github-actions bot commented Jun 13, 2025

Documentation preview for this PR (built with commit 6729597; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 15, 2025
It contains tests that are not relevant for the meson build

We extract the `test_executable` function to `__init__.py`, since it is
still used in other files, and leave only the tests in `cmdline.py`.

URL: sagemath#40252
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 17, 2025
sagemathgh-40252: Don't install sage/tests/cmdline.py with meson
    
It contains tests that are not relevant for the meson build

We extract the `test_executable` function to `__init__.py`, since it is
still used in other files, and leave only the tests in `cmdline.py`.
    
URL: sagemath#40252
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 18, 2025
sagemathgh-40252: Don't install sage/tests/cmdline.py with meson
    
It contains tests that are not relevant for the meson build

We extract the `test_executable` function to `__init__.py`, since it is
still used in other files, and leave only the tests in `cmdline.py`.
    
URL: sagemath#40252
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 21, 2025
sagemathgh-40252: Don't install sage/tests/cmdline.py with meson
    
It contains tests that are not relevant for the meson build

We extract the `test_executable` function to `__init__.py`, since it is
still used in other files, and leave only the tests in `cmdline.py`.
    
URL: sagemath#40252
Reported by: Antonio Rojas
Reviewer(s): Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants