Skip to content

Add Batyrev's construction of toric varieties to toric library #40270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

local-ring
Copy link
Contributor

This is implementation of Batyrev's paper in 1991 and 1999 on construction of toric varieties of Picard number 3 and toric Fano 3-fold/4-fold.

Under construction, not ready for review..

Part of #40269

cc: @tscrim

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@tscrim tscrim added the gsoc: 2025 Tag for GSoC2025 issues/PRs label Jun 19, 2025
Copy link

github-actions bot commented Jun 19, 2025

Documentation preview for this PR (built with commit cead6d5; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@fchapoton
Copy link
Contributor

You need to add the new file to the meson build system, probably to src/sage/schemes/toric/meson.build

@fchapoton
Copy link
Contributor

I have done it for you. Beware to pull the branch before doing further work.

@fchapoton
Copy link
Contributor

you need to fix the linter (see Lint in the checks) and also

/home/runner/work/sage/sage/src/sage/schemes/toric/batyrev.py:7:8 - error: "sys" is imported more than once (reportDuplicateImport)
35380
Error: "sys" is imported more than once (reportDuplicateImport)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gsoc: 2025 Tag for GSoC2025 issues/PRs s: needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants