Skip to content

Hide variants and attributes if product has none#179

Merged
dominik-zeglen merged 3 commits into
masterfrom
fix/hide-variants-if-not-created
Sep 30, 2019
Merged

Hide variants and attributes if product has none#179
dominik-zeglen merged 3 commits into
masterfrom
fix/hide-variants-if-not-created

Conversation

@dominik-zeglen
Copy link
Copy Markdown
Contributor

I want to merge this change because it keeps dashboard up to date with designs.

Pull Request Checklist

  1. All visible strings are translated with proper context.
  2. All data-formatting is locale-aware (dates, numbers, and so on).
  3. Translated strings are extracted to .pot file.
  4. Number of API calls is optimized.
  5. The changes are tested.
  6. Type definitions are up to date.
  7. Changes are mentioned in the changelog.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 25, 2019

Codecov Report

Merging #179 into master will increase coverage by 0.02%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #179      +/-   ##
=========================================
+ Coverage   73.27%   73.3%   +0.02%     
=========================================
  Files         538     538              
  Lines        5467    5472       +5     
  Branches      943     947       +4     
=========================================
+ Hits         4006    4011       +5     
+ Misses       1297    1296       -1     
- Partials      164     165       +1
Impacted Files Coverage Δ
...c/storybook/stories/products/ProductCreatePage.tsx 25% <ø> (ø) ⬆️
...components/ProductCreatePage/ProductCreatePage.tsx 92.3% <0%> (-3.7%) ⬇️
...c/storybook/stories/products/ProductUpdatePage.tsx 57.89% <100%> (+7.89%) ⬆️
...components/ProductUpdatePage/ProductUpdatePage.tsx 93.93% <100%> (+0.18%) ⬆️
...cts/components/ProductVariants/ProductVariants.tsx 54.16% <66.66%> (+4.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b0b99f...5b5b62b. Read the comment docs.

@dominik-zeglen dominik-zeglen force-pushed the fix/hide-variants-if-not-created branch from 28f2c04 to cace4ac Compare September 30, 2019 15:27
@dominik-zeglen dominik-zeglen merged commit 1be6d8a into master Sep 30, 2019
@dominik-zeglen dominik-zeglen deleted the fix/hide-variants-if-not-created branch September 30, 2019 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants