Refactor authorization#624
Merged
Merged
Conversation
Co-authored-by: Krzysztof Wolski <krzysztof.k.wolski@gmail.com>
orzechdev
approved these changes
Jul 27, 2020
krzysztofwolski
approved these changes
Jul 28, 2020
Contributor
krzysztofwolski
left a comment
krzysztofwolski
left a comment
There was a problem hiding this comment.
Besides API_URI comment everything looks 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I want to merge this change because it fixes bugs and adds tests. Also handles expired tokens.
PR intended to be tested with API branch: master
Pull Request Checklist
Test environment config
API_URI=https://master.staging.saleor.rocks/graphql/