Fix cleanup release workflow#6461
Conversation
|
There was a problem hiding this comment.
Pull request overview
Adjusts the “Cleanup After Release” GitHub Actions workflow to better detect when a release PR has been merged, so it can open a cleanup PR back to main.
Changes:
- Update the release-merge detection logic from matching
\[automated]to matchingPrepare release.
| COMMIT_MSG="${{ github.event.head_commit.message }}" | ||
|
|
||
| if echo "$COMMIT_MSG" | grep -q "\[automated\]"; then | ||
| if echo "$COMMIT_MSG" | grep -q "Prepare release"; then |
There was a problem hiding this comment.
The release-detection criteria is now inconsistent with how the release PR is created. deploy-staging-and-prepare-release.yaml configures Changesets to create the release commit as Release <branch> [automated] (not Prepare release ...), so this grep "Prepare release" will likely never match the head commit message in the same cases where the job-level if: contains(..., 'Release 3.22') allows the job to run. Result: is_release_merge will be false and the cleanup PR won’t be created. Consider aligning both checks to the same source of truth (e.g., match Release $CURRENT_RELEASE and/or [automated], or broaden to accept both patterns and update the job-level if accordingly).
| if echo "$COMMIT_MSG" | grep -q "Prepare release"; then | |
| if echo "$COMMIT_MSG" | grep -qE "Prepare release|Release $CURRENT_RELEASE"; then |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6461 +/- ##
========================================
Coverage 43.58% 43.58%
========================================
Files 2585 2585
Lines 44985 44985
Branches 10147 10541 +394
========================================
Hits 19607 19607
Misses 25338 25338
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Scope of the change