Skip to content

Fix cleanup release workflow#6461

Merged
lkostrowski merged 3 commits into
mainfrom
lkostrowski/fix-changeset-check
Mar 25, 2026
Merged

Fix cleanup release workflow#6461
lkostrowski merged 3 commits into
mainfrom
lkostrowski/fix-changeset-check

Conversation

@lkostrowski
Copy link
Copy Markdown
Member

Scope of the change

  • I confirm I added ripples for changes (see src/ripples) or my feature doesn't contain any user-facing changes
  • I used analytics "trackEvent" for important events

Copilot AI review requested due to automatic review settings March 23, 2026 12:32
@lkostrowski lkostrowski requested a review from a team as a code owner March 23, 2026 12:32
@lkostrowski lkostrowski enabled auto-merge (squash) March 23, 2026 12:32
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Mar 23, 2026

⚠️ No Changeset found

Latest commit: 8fc67e9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

witoszekdev
witoszekdev previously approved these changes Mar 23, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the “Cleanup After Release” GitHub Actions workflow to better detect when a release PR has been merged, so it can open a cleanup PR back to main.

Changes:

  • Update the release-merge detection logic from matching \[automated] to matching Prepare release.

COMMIT_MSG="${{ github.event.head_commit.message }}"

if echo "$COMMIT_MSG" | grep -q "\[automated\]"; then
if echo "$COMMIT_MSG" | grep -q "Prepare release"; then
Copy link

Copilot AI Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release-detection criteria is now inconsistent with how the release PR is created. deploy-staging-and-prepare-release.yaml configures Changesets to create the release commit as Release <branch> [automated] (not Prepare release ...), so this grep "Prepare release" will likely never match the head commit message in the same cases where the job-level if: contains(..., 'Release 3.22') allows the job to run. Result: is_release_merge will be false and the cleanup PR won’t be created. Consider aligning both checks to the same source of truth (e.g., match Release $CURRENT_RELEASE and/or [automated], or broaden to accept both patterns and update the job-level if accordingly).

Suggested change
if echo "$COMMIT_MSG" | grep -q "Prepare release"; then
if echo "$COMMIT_MSG" | grep -qE "Prepare release|Release $CURRENT_RELEASE"; then

Copilot uses AI. Check for mistakes.
@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 43.58%. Comparing base (c973d5a) to head (8fc67e9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6461    +/-   ##
========================================
  Coverage   43.58%   43.58%            
========================================
  Files        2585     2585            
  Lines       44985    44985            
  Branches    10147    10541   +394     
========================================
  Hits        19607    19607            
  Misses      25338    25338            
  Partials       40       40            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lkostrowski lkostrowski requested a review from witoszekdev March 23, 2026 14:15
@lkostrowski lkostrowski added the skip changeset Use if your changes doesn't need entry in changelog label Mar 23, 2026
Copilot AI review requested due to automatic review settings March 25, 2026 12:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

@lkostrowski lkostrowski merged commit 955b492 into main Mar 25, 2026
20 of 21 checks passed
@lkostrowski lkostrowski deleted the lkostrowski/fix-changeset-check branch March 25, 2026 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip changeset Use if your changes doesn't need entry in changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants