fix: distinguish between no samesite and samesite=none#240
Merged
Conversation
wjhsf
reviewed
Jun 23, 2022
2 tasks
awaterma
approved these changes
Jul 11, 2022
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
I think we should add a note for this p/r into the changelog for 4.1; we can do that in a separate p/r, but I think we may want to do it here so we don't miss the note on release.
Member
|
@wjhsf -- anything holding us back here? Perhaps we can try and discuss in our meeting tomorrow? |
wjhsf
approved these changes
Jul 26, 2022
adamjmcgrath
added a commit
to auth0/nextjs-auth0
that referenced
this pull request
Jun 14, 2023
wjhsf
pushed a commit
that referenced
this pull request
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #191