Switch from jest to vitest #510
Merged
+2,916
−5,068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Colin Casey <[email protected]>
version bump caused tests to break
left over from vows?
implicit cast to string breaks
colincasey
requested changes
Apr 10, 2025
Contributor
colincasey
left a comment
colincasey
left a comment
There was a problem hiding this comment.
A couple small changes here @wjhsf but overall this looks good. Very impressed with the speed compared to Jest 😄
colincasey
reviewed
Apr 10, 2025
colincasey
reviewed
Apr 10, 2025
colincasey
reviewed
Apr 10, 2025
colincasey
previously approved these changes
Apr 11, 2025
missed during merge
colincasey
approved these changes
Apr 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vitest has better ESM support than jest and is faster. Running tests 10x on my local machine took 24 seconds with jest, but only 9 seconds with vitest.
Since vitest requires ESM, this PR is built on #506.