Skip to content

Type checking improvements #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

bringhurst
Copy link

@bringhurst bringhurst commented Apr 27, 2022

- Add a PEP 561 marker file (py.typed).
- Run mypy during CI.
- Update black to avoid pallets/click#2225
- Update mkdocs to avoid mkdocs/mkdocs#2799
- Disable mkdocs strict mode to avoid mkdocs/mkdocs#2252
@bringhurst
Copy link
Author

bringhurst commented Apr 27, 2022

Note the ignore lines in mypy.ini.

#
# Please do not add any additional mypy ignores in this section!
#

[mypy-devtools.utils]
# FIXME: Remove this ignore after fixing type errors.
ignore_errors = true

[mypy-devtools.prettier]
# FIXME: Remove this ignore after fixing type errors.
ignore_errors = true

[mypy-devtools.ansi]
# FIXME: Remove this ignore after fixing type errors.
ignore_errors = true

[mypy-devtools.debug]
# FIXME: Remove this ignore after fixing type errors.
ignore_errors = true

This was done so mypy warnings/errors can be fixed in bite-sized PRs. Fixing all of those at once would be quite a large change.

If this PR is merged, a new issue should be opened to track fixing these.

@bringhurst
Copy link
Author

Discarding due to inactivity.

@samuelcolvin
Copy link
Owner

So sorry, I missed this complete.

Feel free to reopen this and I'll review it this week.

@samuelcolvin
Copy link
Owner

Don't worry, I've fixed this in #107.

@bringhurst
Copy link
Author

No hard feelings. 😄

I was just bulk closing old PRs.

TY for fixing it up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants