Skip to content

adding new StringNoHyphens func#94

Open
bpgriner wants to merge 5 commits intosatori:masterfrom
bpgriner:string-no-hyphens
Open

adding new StringNoHyphens func#94
bpgriner wants to merge 5 commits intosatori:masterfrom
bpgriner:string-no-hyphens

Conversation

@bpgriner
Copy link
Copy Markdown

@bpgriner bpgriner commented Feb 5, 2019

No description provided.

@coveralls
Copy link
Copy Markdown

coveralls commented Feb 5, 2019

Coverage Status

Coverage increased (+0.02%) to 97.538% when pulling ffc5e1e on bpgriner:string-no-hyphens into b2ce238 on satori:master.

@inliquid
Copy link
Copy Markdown

inliquid commented Feb 5, 2019

You're welcome.

// Returns string representation of UUID without hyphens.
func (u UUID) StringNoHyphens() string {
	return hex.EncodeToString(u[:])
}

@bpgriner
Copy link
Copy Markdown
Author

bpgriner commented Feb 5, 2019

looks like the build failed before the tests even ran:

exit status 1: # github.com/satori/go.uuid
codec_test.go:27:2: cannot find package "gopkg.in/check.v1" in any of:
	/home/travis/.gimme/versions/go1.6.4.linux.amd64/src/gopkg.in/check.v1 (from $GOROOT)
	/home/travis/gopath/src/gopkg.in/check.v1 (from $GOPATH)
FAIL	github.com/satori/go.uuid [setup failed]

can another build be kicked off?

@bpgriner bpgriner closed this Feb 11, 2019
@bpgriner bpgriner reopened this Feb 11, 2019
Comment thread uuid.go Outdated
Co-Authored-By: bpgriner <bpgriner@users.noreply.github.com>
@bpgriner
Copy link
Copy Markdown
Author

bpgriner commented Mar 4, 2019

@tariq1890 I updated the comment 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants