Skip to content

Conversation

@CeptForHer
Copy link
Contributor

Description

Edit sm_sleuth_actions description for extra option to kick instead of ban or notify
Add new #define LENGTH_KICK for kick action
Add in LENGTH_KICK case to SQL_CheckHim function

Added new translation to sleuth_phrases called sleuth_kicktext

Motivation and Context

Gives server owners the ability to only kick the user from the server instead of fully ban them, giving them more insight as to why they cannot join on an alternate account.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Add Sleuth Action to kick clients instead instead of banning them with a translation message as the reason
Add sourcesleuth_kicktext for proposed addition of sleuth kick action
Update sbpp_sleuth.phrases.txt
Copy link
Contributor

@TheByKotik TheByKotik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote for. This works and why not.

@m0rbit1989
Copy link

error ;(

L 08/23/2020 - 11:07:59: [SM] Exception reported: String formatted incorrectly - parameter 4 (total 3)
L 08/23/2020 - 11:07:59: [SM] Blaming: sbpp_sleuth.smx
L 08/23/2020 - 11:07:59: [SM] Call stack trace:
L 08/23/2020 - 11:07:59: [SM] [0] KickClient
L 08/23/2020 - 11:07:59: [SM] [1] Line 232, D:\sm_1.10\addons\sourcemod\scripting\sbpp_sleuth.sp::SQL_CheckHim

@CeptForHer
Copy link
Contributor Author

@Groruk is this good to merge or is there an issue in need of fixing?

@crashzk
Copy link

crashzk commented Feb 11, 2021

I believe it would be interesting to apply this change to the option to ban groups and friends that you have on the panel.
image
Option to just kick them would be perfect too.

@Groruk Groruk merged commit 8edb845 into sbpp:v1.x Jul 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants