Speed up ban list page load times with indexing. #691
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added two indices to the {prefix}_bans table and split the subquery for the ban history count into two on the ban list page.
Motivation and Context
Current ban history count subquery does not scale with a large number of rows in {prefix}_bans table and stalls ban list page load.
How Has This Been Tested?
Environment: Linux server running Apache with PHP 7.2 + MySQL 5.7.27
Load times on the ban list page while having 3.6k total bans have now been reduced from around 13 seconds to 1.
Please advise on the version number bump and updater file changes.
Types of changes
Checklist: