Fix "Undefined index: HTTPS" warning notice when not using HTTPS #732
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the page is loaded through HTTP instead of HTTPS the login page shows a PHP notice on the page:
Undefined index: HTTPSDescription
Added
isset()check for$_SERVER['HTTPS']and handle case where a web server config has the value set tooff.Motivation and Context
This error is hidden from public view with
display_errors = Offinphp.inibut should still be corrected.How Has This Been Tested?
Tested on Linux with Apache 2.4.29 / PHP 7.2.24
Page now loads without the error. Steam OAuth login redirects appropriately for both HTTP and HTTPS.
Types of changes
Checklist: