Skip to content

Conversation

@Groruk
Copy link
Member

@Groruk Groruk commented Jul 11, 2021

Description

This PR updates the SourceQuery library used to the latest version, to support the new S2C_CHALLENGE packet. (https://developer.valvesoftware.com/wiki/Server_queries#A2S_INFO)

Fixes #734
Fixes #733

Also, with this PR the GMP extension has also been made mandatory to run the sbpp webpanel, this will give us some further library options in the future, like the SteamID library (https://github.com/xPaw/SteamID.php)

Side effect

The newest SourceQuery version requires PHP version 7.4 or higher, this means the minimum PHP version requirement in sbpp will be bumped to 7.4

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

Groruk added 5 commits July 11, 2021 17:26
See requirements for the newest SourceQuery lib version (https://github.com/xPaw/PHP-Source-Query)
Part of the requirements for non 64-bit PHP versions to run SourceQuery, but this will also help us to use libraries like SteamID (https://github.com/xPaw/SteamID.php) in the future.
@Groruk Groruk merged commit 6e69c98 into sbpp:v1.x Jul 11, 2021
@jjambo789
Copy link

jjambo789 commented Jul 12, 2021

If I update to the newest PHP and MySQL version, Is it possible to migrate MySQL data from previous versions? (my current MySQL version 5.7 / PHP version 5.6)

Sorry, I am not good at English.

@xLeviNx
Copy link

xLeviNx commented Jul 12, 2021

Running into these errors:

Fatal error: Uncaught Error: Class 'xPaw\SourceQuery\SourceQuery' not found in /home/supercen/public_html/sourcebans/includes/sb-callback.php:1386 Stack trace: #0 /home/supercen/public_html/sourcebans/includes/xajax.inc.php(1090): ServerHostPlayers('29', 'servers', '', '3', '-1', '1', '70') #1 /home/supercen/public_html/sourcebans/includes/xajax.inc.php(739): xajax->_callFunction('ServerHostPlaye...', Array) #2 /home/supercen/public_html/sourcebans/index.php(24): xajax->processRequests() #3 {main} thrown in /home/supercen/public_html/sourcebans/includes/sb-callback.php on line 1386 You have whitespace in your response.

@Groruk
Copy link
Member Author

Groruk commented Jul 12, 2021

If I update to the newest PHP and MySQL version, Is it possible to migrate MySQL data from previous versions? (my current MySQL version 5.7 / PHP version 5.6)

Sorry, I am not good at English.

Yes, sbpp has an updater that will update the database to the current version.
See https://sbpp.dev/docs/updating/ for more infos. (Just be sure to make a full backup of our database before updating)

@Groruk
Copy link
Member Author

Groruk commented Jul 12, 2021

Running into these errors:

Fatal error: Uncaught Error: Class 'xPaw\SourceQuery\SourceQuery' not found in /home/supercen/public_html/sourcebans/includes/sb-callback.php:1386 Stack trace: #0 /home/supercen/public_html/sourcebans/includes/xajax.inc.php(1090): ServerHostPlayers('29', 'servers', '', '3', '-1', '1', '70') #1 /home/supercen/public_html/sourcebans/includes/xajax.inc.php(739): xajax->_callFunction('ServerHostPlaye...', Array) #2 /home/supercen/public_html/sourcebans/index.php(24): xajax->processRequests() #3 {main} thrown in /home/supercen/public_html/sourcebans/includes/sb-callback.php on line 1386 You have whitespace in your response.

SourceQuery is now a composer dependency, so you will have to run composer install again to download it.

@jjambo789
Copy link

If I update to the newest PHP and MySQL version, Is it possible to migrate MySQL data from previous versions? (my current MySQL version 5.7 / PHP version 5.6)
Sorry, I am not good at English.

Yes, sbpp has an updater that will update the database to the current version.
See https://sbpp.dev/docs/updating/ for more infos. (Just be sure to make a full backup of our database before updating)

Thank you so much.
I'll try it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No support for a2s challenge - Update SourceQuery include Server are not showing.

3 participants