Fix "undefined offset" warning notice on ban list page for IP address bans #741
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ban list page does not properly check for a valid SteamID2 before converting to a SteamID3, which happens for the IP address ban type that does not require a Steam ID (defaults to
0in the_banstable). This produces warnings due to attempting to manually split the string into parts.Description
Switch to using the
SteamIDlibrary, which has a built-in validity check.Motivation and Context
This error is hidden from public view with display_errors = Off in php.ini but should still be corrected.
How Has This Been Tested?
Tested on Linux with Apache 2.4.29 / PHP 7.4.21
Page now loads without the error.
Types of changes
Checklist: