Skip to content

Conversation

@Sarrus1
Copy link
Contributor

@Sarrus1 Sarrus1 commented Jan 28, 2022

Description

Added an include file and two natives for sbppchecker, which allow to get the number of bans and comms ban for a client, synchronously.

Motivation and Context

It is useful for calladmin plugins to send information on the target, so admin can decide more easily what to do.

How Has This Been Tested?

On the latest version of sbpp, with an external plugin which calls the native when a command is called in the server.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@DosMike
Copy link

DosMike commented Feb 17, 2022

Hey, I was looking for this feature. Nice to see I don't have to PR it now :D

@DosMike
Copy link

DosMike commented Feb 17, 2022

A forward for might be nice to have too for when data are loaded.
Maybe something like forward void SBCheckerOnClientLoaded(int client, int gamebans, int commbans)?

@ashort96
Copy link

@Sarrus1 can you rebase this to thephp81 branch?

@Sarrus1 Sarrus1 changed the base branch from v1.x to php81 September 17, 2022 15:33
Copy link

@ashort96 ashort96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants