Skip to content

Conversation

@maxime1907
Copy link
Contributor

@maxime1907 maxime1907 commented Sep 25, 2022

Description

Add a forward SBPP_OnClientPreAdminCheck to control when OnClientPostAdminCheck will be called.
We can then return a boolean to block the commands that will trigger OnClientPostAdminCheck:

RunAdminCacheChecks(i);
NotifyPostAdminCheck(i);

Motivation and Context

We are using https://github.com/R1KO/Vip-Core and we need to wait for both sourcebans-pp and vip-core to check if the player has a vip and/or an admin status so that we can trigger OnClientPostAdminCheck with the proper sourcemod admin flags

How Has This Been Tested?

In use on https://nide.gg for about two years implemented throught this module:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@maxime1907
Copy link
Contributor Author

cc @Hackmastr

@rumblefrog rumblefrog merged commit e9bea70 into sbpp:php81 Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants