Skip to content

Conversation

@Rushaway
Copy link
Contributor

Description

Related to #820 (comment)

Motivation and Context

No more warning

How Has This Been Tested?

Yep. No more warnings now.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

PHP Warning: Undefined array key "advType" in /pages/admin.admins.php on line 205
PHP Warning: Undefined array key "page" in /pages/admin.admins.php on line 207
@Rushaway Rushaway changed the title More fix about https://github.com/sbpp/sourcebans-pp/issues/820 More fix about #820 Sep 28, 2022
Copy link
Contributor

@Hackmastr Hackmastr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the condition to isset and $i === $_GET....
Thanks!

@Hackmastr Hackmastr merged commit d6e7505 into sbpp:php81 Sep 29, 2022
@Rushaway Rushaway mentioned this pull request Jul 30, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants