Skip to content

Conversation

@Rushaway
Copy link
Contributor

Description

  1. Print the name of the banned client when using target name as arg
    1.1 Get the target name of the user banned via sm_banip
    1.2 Will print target name instead of 'No nickname present'
    1.3 You can still use the command like sm_banip 255.255.22.2 240 Cheat (Will be show as 'No nickname present')

  2. Kick the target banned via sm_banip if the callback succes

  3. Remove extra tabs in AutoAdd part

Motivation and Context

When a banip was made, client aren't kicked and was printed on Sourcebans website as 'No nickname present'

How Has This Been Tested?

  1. sm_banip 255.255.55.5 240 Cheat
  2. sm_banip Rushaway 240 Cheat (in this case if player stil on the server it will be kicked if the CallBack succes)

Screenshots (if appropriate):

  1. image
  2. image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

1.a Get the target name of the user banned via sm_banip (ex : sm_banip Rushaway 240 Cheat)
Will print target name instead of 'No nickname present'
1.b You can still use the command like sm_banip 255.255.22.2 240 Cheat (Will be show as 'No nickname present')
2. Kick the target banned via sm_banip if the callback succes 
3. Remove extra tabs in AutoAdd part
@Hackmastr
Copy link
Contributor

Thanks!

@Hackmastr Hackmastr merged commit e50d3d1 into sbpp:php81 Feb 14, 2023
@Rushaway Rushaway deleted the improve-banip branch March 1, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants