Skip to content

Conversation

@Rushaway
Copy link
Contributor

@Rushaway Rushaway commented Feb 17, 2023

Description

Updating Changelog.md

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.

@Hackmastr
Copy link
Contributor

Thank you very much!

@Hackmastr Hackmastr merged commit 08893d3 into sbpp:php81 Feb 20, 2023
@Rushaway Rushaway deleted the patch-2 branch February 20, 2023 20:36
@rumblefrog
Copy link
Member

I'm not up to date with the changes, but looking at the changelog, what warrants the major version bump to 2.x?

@Rushaway
Copy link
Contributor Author

@rumblefrog You would prefer 1.8.0 ? I can make a PR with all files related to it.

@rumblefrog
Copy link
Member

1.8.x is more fitting; trying to stick with semver versioning, my initial impression seeing 2.x is that it's a breaking change.

@Rushaway Rushaway mentioned this pull request Feb 21, 2023
7 tasks
@Rushaway
Copy link
Contributor Author

@rumblefrog Here you go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants