Skip to content

fix(instance): add zone to update volume request #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
May 12, 2025

Conversation

Laure-di
Copy link
Contributor

Issue cmd

scw instance server create name=test image=ubuntu_noble type=PLAY2-NANO zone=fr-par-2 root-volume=sbs:10G:15000 additional-volumes.0=sbs:10G:15000 --wait -ojson --debug

Response

---------- Scaleway SDK REQUEST 10 (a24063ba) : ----------
PATCH /block/v1alpha1/zones/fr-par-1/volumes/xxxxxxxxx HTTP/1.1
Host: api.scaleway.com
User-Agent: scaleway-sdk-go/v1.0.0-beta.33.0.20250422095315-6f998f4655ec (go1.24.1; darwin; arm64) scaleway-cli/2.0.0+dev
Content-Length: 19
Content-Type: application/json
X-Auth-Token: dd0f2cd8-xxxx-xxxx-xxxx-xxxxxxxxxxxx
Accept-Encoding: gzip

{"perf_iops":15000}

---------- Scaleway SDK RESPONSE 10 (a24063ba) : ----------
HTTP/2.0 500 Internal Server Error
Content-Length: 28
Content-Security-Policy: default-src 'none'; frame-ancestors 'none'
Content-Type: application/json
Date: Mon, 12 May 2025 09:18:36 GMT
Server: Scaleway API Gateway (fr-par-1;edge03)
Strict-Transport-Security: max-age=63072000
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
X-Request-Id: 57432a0a-7048-45d8-80d9-bb36a60c7efd

{"message":"internal error"}

Root Cause

The CLI command targets zone=fr-par-2, but a volume operation is mistakenly attempted in fr-par-1. This zone mismatch triggers a 500 Internal Server Error.

Expected behavior: The API should return a 404 Not Found when attempting to operate on a resource in the wrong zone. This will be corrected in a future update.

dependabot bot and others added 9 commits May 12, 2025 12:35
)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@Laure-di Laure-di requested a review from a team as a code owner May 12, 2025 11:01
@github-actions github-actions bot added the instance Instance issues, bugs and feature requests label May 12, 2025
@Laure-di Laure-di self-assigned this May 12, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.20%. Comparing base (5bf53e0) to head (4ee5e78).
Report is 612 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (4ee5e78). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (4ee5e78)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4710       +/-   ##
===========================================
- Coverage   75.45%   55.20%   -20.26%     
===========================================
  Files         202      311      +109     
  Lines       44323    79242    +34919     
===========================================
+ Hits        33444    43743    +10299     
- Misses       9653    34095    +24442     
- Partials     1226     1404      +178     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@remyleone remyleone added this pull request to the merge queue May 12, 2025
Merged via the queue into scaleway:master with commit ce84dae May 12, 2025
14 checks passed
Laure-di added a commit to scaleway-bot/scaleway-cli that referenced this pull request May 15, 2025
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Scaleway Bot <[email protected]>
Co-authored-by: Jonathan R. <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
instance Instance issues, bugs and feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants