Skip to content

fix(instance): delete sbs volumes on instance termination #4848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Mia-Cross
Copy link
Contributor

Closes #4676

@Mia-Cross Mia-Cross self-assigned this Jun 18, 2025
@Mia-Cross Mia-Cross added bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues labels Jun 18, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jun 18, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 12 lines in your changes missing coverage. Please review.

Project coverage is 56.39%. Comparing base (5bf53e0) to head (9e83727).
Report is 692 commits behind head on master.

Files with missing lines Patch % Lines
...nal/namespaces/instance/v1/custom_server_action.go 73.33% 7 Missing and 5 partials ⚠️

❗ There is a different number of reports uploaded between BASE (5bf53e0) and HEAD (9e83727). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (5bf53e0) HEAD (9e83727)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4848       +/-   ##
===========================================
- Coverage   75.45%   56.39%   -19.06%     
===========================================
  Files         202      314      +112     
  Lines       44323    78391    +34068     
===========================================
+ Hits        33444    44212    +10768     
- Misses       9653    32768    +23115     
- Partials     1226     1411      +185     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Mia-Cross Mia-Cross marked this pull request as ready for review June 18, 2025 22:07
@Mia-Cross Mia-Cross requested review from a team and remyleone as code owners June 18, 2025 22:07
@Mia-Cross Mia-Cross marked this pull request as draft June 18, 2025 22:25
@Mia-Cross Mia-Cross force-pushed the instance_terminate_delete_volumes branch from 3dd7ebd to 9e83727 Compare June 19, 2025 14:08
@Mia-Cross Mia-Cross marked this pull request as ready for review June 19, 2025 14:22
@remyleone remyleone added this pull request to the merge queue Jun 19, 2025
Merged via the queue into scaleway:master with commit d1147d8 Jun 19, 2025
15 checks passed
@Mia-Cross Mia-Cross deleted the instance_terminate_delete_volumes branch June 19, 2025 15:11
Laure-di pushed a commit to Laure-di/scaleway-cli that referenced this pull request Jun 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug instance Instance issues, bugs and feature requests priority:highest Bugs filled by customers, security issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Have a better handling of block volume when an instance server is terminated
3 participants