Skip to content

feat: remove deprecated props in Icon CodeEditor and Bullet #5297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: beta
Choose a base branch
from

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Refactor

Summarise concisely:

BREAKING CHANGES

Deprecated props removed:

  • CodeEditor: prop "title" removed -> use "label" instead
  • Icon: prop "color" removed -> use "sentiment" instead
  • Icon: prop "size" can only be "xsmall", "small", "medium", "large", "xlarge" or "xxlarge"
  • Bullet: prop "text" removed -> use "children" instead

@lisalupi lisalupi requested a review from a team June 27, 2025 09:49
@lisalupi lisalupi self-assigned this Jun 27, 2025
@lisalupi lisalupi requested review from fabienhebert and JulienSaguez and removed request for a team June 27, 2025 09:49
@lisalupi lisalupi requested a review from matthprost as a code owner June 27, 2025 09:49
Copy link

changeset-bot bot commented Jun 27, 2025

🦋 Changeset detected

Latest commit: 8958afc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/plus Major
@ultraviolet/icons Major
@ultraviolet/ui Major
@ultraviolet/form Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi force-pushed the feat/remove-deprecated-icon-code-editor-bullet branch from 7811e79 to 2014c8c Compare June 27, 2025 09:58
@lisalupi lisalupi requested review from johnrazeur and a team as code owners June 27, 2025 09:58
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.63%. Comparing base (a2ac9c4) to head (8958afc).
Report is 8 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5297      +/-   ##
==========================================
- Coverage   87.63%   87.63%   -0.01%     
==========================================
  Files         229      228       -1     
  Lines        7847     7822      -25     
  Branches     3437     3431       -6     
==========================================
- Hits         6877     6855      -22     
+ Misses        970      967       -3     
Files with missing lines Coverage Δ
packages/ui/src/components/Bullet/index.tsx 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2ac9c4...8958afc. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants