Skip to content

fix: remove deprecated props Menu, List and Link #5308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Refactor

Summarise concisely:

What is expected?

BREAKING CHANGES

Deprecated props removed:

  • Link: prop "sentiment" can only by "primary" or "info" (default value) now
  • List.Cell: prop "preventClick" removed (it is now default behavior)
  • Menu: prop "size" and "maxWidth" removed

@lisalupi lisalupi requested a review from a team June 30, 2025 13:52
@lisalupi lisalupi self-assigned this Jun 30, 2025
@lisalupi lisalupi requested review from BABAK0T0 and matthprost and removed request for a team June 30, 2025 13:52
@lisalupi lisalupi requested a review from matthprost as a code owner June 30, 2025 13:52
Copy link

changeset-bot bot commented Jun 30, 2025

🦋 Changeset detected

Latest commit: c5f3f75

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Major
@ultraviolet/form Major
@ultraviolet/plus Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.64%. Comparing base (c982969) to head (dcc050b).
Report is 6 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5308      +/-   ##
==========================================
+ Coverage   87.63%   87.64%   +0.01%     
==========================================
  Files         229      228       -1     
  Lines        7845     7788      -57     
  Branches     3437     3462      +25     
==========================================
- Hits         6875     6826      -49     
+ Misses        970      962       -8     
Files with missing lines Coverage Δ
packages/ui/src/components/Link/index.tsx 100.00% <100.00%> (+3.26%) ⬆️
packages/ui/src/components/List/Cell.tsx 100.00% <100.00%> (+15.38%) ⬆️
packages/ui/src/components/List/Row.tsx 92.62% <100.00%> (ø)
packages/ui/src/components/Menu/MenuContent.tsx 98.68% <100.00%> (-0.02%) ⬇️
...ages/ui/src/components/Toaster/components/Link.tsx 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb7243...dcc050b. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants