Skip to content

feat: remove deprecated Modal, RadioGroup, Separator and Text #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jul 1, 2025

Summary

Type

  • Refactor

Summarise concisely:

The following changes where made:

BREAKING CHANGES

Deprecated props removed:

  • Modal:
    • prop "customDialogBackdropStyles" removed -> use "backdropClassName" instead to style the backdrop
    • prop "customDialogStyles" removed -> use "customDialogStyles" instead to style the dialog
    • prop "width" removed -> use "size" instead (same possible values)
    • prop "opened" removed -> use "open" instead
    • prop "onOpen" removed -> use "show" instead (ModalState)
    • prop "onClose" removed -> use "close" instead (ModalState)
    • prop "hide" removed -> use "close" instead (ModalState)
  • RadioGroup.Radio: prop "name" removed, it is automatically passed from the parent RadioGroup
  • Separator: prop "color" removed -> use "sentiment" instead
  • Text: prop "color" removed -> use "sentiment" instead

@lisalupi lisalupi requested a review from a team July 1, 2025 08:41
@lisalupi lisalupi self-assigned this Jul 1, 2025
@lisalupi lisalupi requested review from fabienhebert, JulienSaguez and a team and removed request for a team, fabienhebert and JulienSaguez July 1, 2025 08:41
@lisalupi lisalupi requested review from johnrazeur, a team and matthprost as code owners July 1, 2025 08:42
Copy link

changeset-bot bot commented Jul 1, 2025

🦋 Changeset detected

Latest commit: eaf587d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Major
@ultraviolet/form Major
@ultraviolet/plus Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@lisalupi lisalupi force-pushed the feat/remove-deprecated-modal-radiogroups-separator-text branch from 078fad0 to eaf587d Compare July 1, 2025 08:42
@lisalupi lisalupi changed the title feat: Rremove deprecated Modal, RadioGroup, Separator and Text feat: remove deprecated Modal, RadioGroup, Separator and Text Jul 1, 2025
Copy link

codecov bot commented Jul 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.62%. Comparing base (c982969) to head (eaf587d).
Report is 7 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5310      +/-   ##
==========================================
- Coverage   87.63%   87.62%   -0.02%     
==========================================
  Files         229      228       -1     
  Lines        7845     7811      -34     
  Branches     3437     3425      -12     
==========================================
- Hits         6875     6844      -31     
+ Misses        970      967       -3     
Files with missing lines Coverage Δ
...kages/ui/src/components/LineChart/CustomLegend.tsx 96.55% <100.00%> (ø)
packages/ui/src/components/Modal/ModalContent.tsx 100.00% <100.00%> (ø)
...ages/ui/src/components/Modal/components/Dialog.tsx 76.06% <100.00%> (+0.20%) ⬆️
.../ui/src/components/Modal/components/Disclosure.tsx 92.85% <ø> (ø)
packages/ui/src/components/Modal/index.tsx 94.11% <100.00%> (-0.33%) ⬇️
packages/ui/src/components/RadioGroup/index.tsx 84.37% <ø> (-0.48%) ⬇️
packages/ui/src/components/Separator/index.tsx 100.00% <100.00%> (ø)
packages/ui/src/components/Table/HeaderCell.tsx 97.72% <100.00%> (+0.05%) ⬆️
packages/ui/src/components/Text/index.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcb7243...eaf587d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants