Skip to content

fix(DateInput): onChange trigger #5324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: beta
Choose a base branch
from
Open

fix(DateInput): onChange trigger #5324

wants to merge 1 commit into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Jul 3, 2025

Summary

Type

  • Bug

Summarise concisely:

DateInput: value changes onBlur instead of onChange to avoid wrong dates while the user is typing

@lisalupi lisalupi requested review from radhi-nasser-scaleway and a team July 3, 2025 15:19
@lisalupi lisalupi self-assigned this Jul 3, 2025
@lisalupi lisalupi removed the request for review from a team July 3, 2025 15:19
@lisalupi lisalupi requested a review from johnrazeur as a code owner July 3, 2025 15:19
@lisalupi lisalupi requested a review from JulienSaguez July 3, 2025 15:19
@lisalupi lisalupi requested review from a team and matthprost as code owners July 3, 2025 15:19
@lisalupi lisalupi added the bug Something isn't working label Jul 3, 2025
Copy link

changeset-bot bot commented Jul 3, 2025

🦋 Changeset detected

Latest commit: 89d991d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jul 3, 2025

Codecov Report

Attention: Patch coverage is 97.67442% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.71%. Comparing base (c982969) to head (89d991d).
Report is 14 commits behind head on beta.

Files with missing lines Patch % Lines
packages/ui/src/components/DateInput/helpers.ts 96.77% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5324      +/-   ##
==========================================
+ Coverage   87.63%   87.71%   +0.07%     
==========================================
  Files         229      228       -1     
  Lines        7845     7853       +8     
  Branches     3437     3494      +57     
==========================================
+ Hits         6875     6888      +13     
+ Misses        970      965       -5     
Files with missing lines Coverage Δ
packages/ui/src/components/DateInput/index.tsx 97.53% <100.00%> (+0.97%) ⬆️
packages/ui/src/components/DateInput/helpers.ts 98.48% <96.77%> (-1.52%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8108ff...89d991d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants