complete scipy.signal._savitzky_golay
#124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the file `_savitzky_golay.pyi`. Additionally add `Literal` type annotation for the `use` parameter which can only be "conv" or "dot".
For the file `_savitzy_golay.pyi`. Additionally write a mode type alias for mode to specify the actually allowed strings.
In `_savitzy_golay.pyi`.
jorenham
reviewed
Oct 21, 2024
In the file `_savitzky_golay.pyi`.
jorenham
approved these changes
Oct 21, 2024
Member
jorenham
left a comment
jorenham
left a comment
There was a problem hiding this comment.
Unless you want to change something, I think this we can go ahead and merge this :)
Contributor
Author
Yes should be all done now. |
Member
|
Thanks again @pavyamsiri ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, the stub file
_savitzky_golay.pyihad untyped annotations. This PR adds in the missing type annotations and improves previous ones.The improvements are:
op.CanIndexinstead ofintfor theaxisparameter.useandmodeparametersThis file tends to use
intandfloata lot which could perhaps be replaced byAnyIntandAnyRealhowever, some parameters likewindow_lengthare used as shapes in calls to functions likenp.zeroswhich don't acceptnp.bool_.For simplicity I left the type annotations as the builtin python types but I am open to using more general type annotations to allow numpy dtypes as well. It just might take a bit more testing to check the allowed types.