fix: add miscellaneous fixes before implementing _comp_compgen -P
#1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinomyoga
force-pushed
the
_comp_compgen-P-0
branch
from
a0d8c9e to
991f955
Compare
In the current implementation, an argument --longopt='-MOZ_LOG=xxx' would be doubly split. We avoid splitting the option argument of a long option '--longopt=...'.
akinomyoga
force-pushed
the
_comp_compgen-P-0
branch
from
991f955 to
9fbe788
Compare
|
There are no reviews, but I'll merge this in a few days because these are trivial fixes and this is blocking #1360 for a long time. |
yedayak
approved these changes
Jun 17, 2025
akinomyoga
force-pushed
the
_comp_compgen-P-0
branch
from
35859d6 to
594706a
Compare
yedayak
approved these changes
Jun 17, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
_comp_compgen -PI mentioned in #1358 (comment), I'd like to apply these small changes.